use CPP_CXX_ABI for Python libraries#1960
Merged
Merged
Conversation
Fixes deepmodeling#1958. There was an ImportError from Python when TF and TF's dependency were not installed in the same directory, and one built with PEP 517. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Codecov ReportBase: 63.84% // Head: 63.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1960 +/- ##
==========================================
- Coverage 63.84% 63.76% -0.08%
==========================================
Files 180 180
Lines 16389 16348 -41
==========================================
- Hits 10464 10425 -39
+ Misses 5925 5923 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wanghan-iapcm
approved these changes
Oct 3, 2022
mingzhong15
pushed a commit
to mingzhong15/deepmd-kit
that referenced
this pull request
Jan 15, 2023
Fixes deepmodeling#1958. There was an ImportError from Python when TF and TF's dependency were not installed in the same directory, and one built with PEP 517. The reason is that only TF's parent directory is added to `sys.path`. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1958. There was an ImportError from Python when TF and TF's dependency were not installed in the same directory, and one built with PEP 517.
The reason is that only TF's parent directory is added to
sys.path.